Skip to content

fix(core): takeUntilDestroyed completes immediately if DestroyRef a… - #61847

Closed
atscott wants to merge 1 commit into
angular:mainfrom
atscott:takeUntilDestroyedFix
Closed

fix(core): takeUntilDestroyed completes immediately if DestroyRef a…#61847
atscott wants to merge 1 commit into
angular:mainfrom
atscott:takeUntilDestroyedFix

Conversation

@atscott

@atscott atscott commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

…lready destroyed

Adds fix directly for takeUntilDestroyed to unsubscribe when already destroyed instead of putting
synchronous behavior on DestroyRef.onDestroyed callback as in #58008

fixes #54527

@atscott
fix(core): takeUntilDestroyed completes immediately if DestroyRef a…
6ab7d1c 
…lready destroyed

Adds fix directly for `takeUntilDestroyed` to unsubscribe when already
destroyed instead of putting
synchronous behavior on `DestroyRef.onDestroyed` callback as in angular#58008

fixes angular#54527
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jun 3, 2025
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Jun 3, 2025
@ngbot ngbot Bot added this to the Backlog milestone Jun 3, 2025
@atscott atscott added the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 3, 2025
@pullapprove pullapprove Bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 3, 2025
@atscott atscott mentioned this pull request Jun 3, 2025
Closed
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
@ngbot

ngbot Bot commented Jun 4, 2025

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott added requires: TGP This PR requires a passing TGP before merging is allowed and removed action: merge The PR is ready for merge by the caretaker labels Jun 4, 2025
@pullapprove pullapprove Bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Jun 4, 2025
@atscott

atscott commented Jun 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

TGP

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2025
@kirjs

kirjs commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 2bd3a43.

The changes were merged into the following branches: main, 20.0.x

kirjs pushed a commit that referenced this pull request Jun 4, 2025
@atscott @kirjs
fix(core): takeUntilDestroyed completes immediately if DestroyRef a…
8c60cbf 
…lready destroyed (#61847)

Adds fix directly for `takeUntilDestroyed` to unsubscribe when already
destroyed instead of putting
synchronous behavior on `DestroyRef.onDestroyed` callback as in #58008

fixes #54527

PR Close #61847
@kirjs kirjs closed this in 2bd3a43 Jun 4, 2025
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 5, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

See More

Successfully merging this pull request may close these issues.

NG0911: View has already been destroyed.

3 participants

@atscott @kirjs @alxhub