Skip to content

feat(common): accept undefined inputs in NgTemplateOutlet - #61404

Closed
rslawik wants to merge 1 commit into
angular:mainfrom
rslawik:null-undefined
Closed

feat(common): accept undefined inputs in NgTemplateOutlet#61404
rslawik wants to merge 1 commit into
angular:mainfrom
rslawik:null-undefined

Conversation

@rslawik

@rslawik rslawik commented May 16, 2025

Copy link
Copy Markdown
Contributor

Extend types of inputs to include undefined to avoid ?? null when using singals (e.g. viewChild).

Fixes #51225

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Inputs don't accept undefined

Issue Number: #51225

What is the new behavior?

Accept undefined

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from atscott May 16, 2025 11:00
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: common Issues related to APIs in the @angular/common package labels May 16, 2025
@ngbot ngbot Bot modified the milestone: Backlog May 16, 2025
@pkozlowski-opensource
pkozlowski-opensource removed the request for review from atscott May 21, 2025 14:57
@pullapprove
pullapprove Bot requested review from crisbeto, devversion and mmalerba May 21, 2025 14:57
@rslawik @JeanMeche
feat(common): accept undefined inputs in NgTemplateOutlet
b46b0df 
Extend types of inputs to include `undefined` to avoid `?? null` when using singals (e.g. `viewChild`).

Fixes angular#51225
mmalerba
mmalerba approved these changes May 21, 2025
View reviewed changes

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from kirjs May 21, 2025 15:31
pkozlowski-opensource
pkozlowski-opensource approved these changes May 21, 2025
View reviewed changes

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-general
Reviewed-for: public-api

devversion
devversion approved these changes May 21, 2025
View reviewed changes

@devversion devversion left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a breaking change note when people are relying on the type of those public variables?

Reviewed-for: public-api

@JeanMeche

JeanMeche commented May 21, 2025

Copy link
Copy Markdown
Member

@devversion You're making a good point. If we consider it a breaking change we won't be able to land it in v20.

Maybe let the TGP decide if we consider that breaking ?

@JeanMeche

JeanMeche commented May 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

TGP is "Green" without having to cleanup g3.

I think we can consider this change non breaking.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels May 23, 2025
@atscott

atscott commented May 25, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 82327f2.

The changes were merged into the following branches: main, 20.0.x

@atscott atscott closed this in 82327f2 May 25, 2025
atscott pushed a commit that referenced this pull request May 25, 2025
@rslawik @atscott
feat(common): accept undefined inputs in NgTemplateOutlet (#61404)
2e5362a 
Extend types of inputs to include `undefined` to avoid `?? null` when using singals (e.g. `viewChild`).

Fixes #51225

PR Close #61404
@rslawik
rslawik deleted the null-undefined branch May 31, 2025 16:08
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 1, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes
@devversion devversion devversion approved these changes
+1 more reviewer
@mmalerba mmalerba mmalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

6 participants

@rslawik @JeanMeche @atscott @pkozlowski-opensource @devversion @mmalerba