Conversation
angular-robot
Bot
added
detected: feature
arturovt
reviewed
Apr 2, 2025
AndrewKushnir
approved these changes
Apr 4, 2025
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
devversion
approved these changes
Apr 4, 2025
devversion
left a comment
devversion
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
6 of 8 tasks
atscott
added
action: merge
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
from
April 4, 2025 21:55
b0e32ed to
0a17cdf
Compare
atscott
changed the title
atscott
removed
the
area: common
kirjs
approved these changes
Apr 7, 2025
kirjs
left a comment
kirjs
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
3 times, most recently
from
April 7, 2025 15:56
bf90b0a to
cfdf817
Compare
syamoka
approved these changes
Apr 8, 2025
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
2 times, most recently
from
April 8, 2025 23:56
0d690ec to
dfad3c3
Compare
DerZyklop
suggested changes
Apr 10, 2025
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
from
April 10, 2025 13:56
dfad3c3 to
84c3161
Compare
thePunderWoman
approved these changes
Apr 10, 2025
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: fw-general, public-api
DerZyklop
approved these changes
Apr 11, 2025
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
3 times, most recently
from
April 11, 2025 21:29
9c91b81 to
c6e8860
Compare
…ErrorHandler This commit adds a provider that installs listeners on the browser window to forward unhandled promise rejections and uncaught errors to the `ErrorHandler`. This is useful for both ZoneJS and Zoneless applications. For apps using ZoneJS, errors can reach the window when they happen outside the Angular Zone. For Zoneless apps, any errors not explicitly caught by the framework can reach the window. Without this provider, these errors would otherwise not be reported to `ErrorHandler`. We will/should consider adding this provider to apps by default in the cli. In addition, it should be mentioned in the (to be created) documentation page on error handling in Angular. relates to angular#56240
atscott
force-pushed
the
provideBrowserUnhandledErrorListeners
branch
from
April 11, 2025 22:45
c6e8860 to
37ec7ed
Compare
Contributor
|
This PR was merged into the repository by commit 65adb30. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o ErrorHandler
This commit adds a provider that installs listeners on the browser window to forward unhandled promise rejections and uncaught errors to the
ErrorHandler. This is useful for both ZoneJS and Zoneless applications. For apps using ZoneJS, errors can reach the window when they happen outside the Angular Zone. For Zoneless apps, any errors not explicitly caught by the framework can reach the window. Without this provider, these errors would otherwise not be reported toErrorHandler.We will/should consider adding this provider to apps by default in the cli. In addition, it should be mentioned in the (to be created) documentation page on error handling in Angular.