Skip to content

fix(service-worker): update service worker to handle seeking better for videos #60029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Beanminchild wants to merge 1 commit into from
Closed

fix(service-worker): update service worker to handle seeking better for videos #60029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/service-worker/push/ngsw-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.dev/license
* found in the LICENSE file at https://angular.dev/license.
*/

// Mock `ngsw-worker.js` used for testing the examples.
Expand Down
63 changes: 63 additions & 0 deletions packages/service-worker/worker/src/driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ export class Driver implements Debuggable, UpdateSource {
return;
}

// Calls range request handler
if (req.headers.has('range')) {
event.respondWith(this.handleRangeRequest(req));
return;
}

// The only thing that is served unconditionally is the debug page.
if (requestUrlObj.path === this.ngswStatePath) {
// Allow the debugger to handle the request, but don't affect SW state in any other way.
Expand Down Expand Up @@ -262,6 +268,63 @@ export class Driver implements Debuggable, UpdateSource {
event.respondWith(this.handleFetch(event));
}

// function to handle Range requests
private async handleRangeRequest(req: Request): Promise<Response> {
try {
const response = await fetch(req);
const contentType = response.headers.get('Content-Type');

// Only apply logic to content that is a video
if (!contentType || !contentType.startsWith('video/')) {
return response;
}

const rangeHeader = req.headers.get('range');
if (!rangeHeader) {
return new Response(null, {
status: 416,
statusText: 'Range Not Satisfiable',
});
}

const rangeMatch = /bytes=(\d+)-(\d+)?/.exec(rangeHeader);
if (!rangeMatch) {
return new Response(null, {
status: 416,
statusText: 'Range Not Satisfiable',
});
}

const start = Number(rangeMatch[1]);
const end = rangeMatch[2] ? Number(rangeMatch[2]) : undefined;

const buffer = await response.arrayBuffer();
const contentLength = buffer.byteLength;

const chunk = buffer.slice(start, end ? end + 1 : contentLength);
const chunkLength = chunk.byteLength;

const headers = new Headers(response.headers);
headers.set(
'Content-Range',
`bytes ${start}-${end ? end : contentLength - 1}/${contentLength}`,
);
headers.set('Content-Length', chunkLength.toString());
headers.set('Accept-Ranges', 'bytes');

return new Response(chunk, {
status: 206,
statusText: 'Partial Content',
headers: headers,
});
} catch (error) {
return new Response(null, {
status: 500,
statusText: 'Internal Server Error',
});
}
}

/**
* The handler for message events.
*/
Expand Down