fix(migrations): take care of tests that import both HttpClientModule & HttpClientTestingModule. - #58777
Closed
JeanMeche wants to merge 1 commit into
Closed
fix(migrations): take care of tests that import both HttpClientModule & HttpClientTestingModule.#58777JeanMeche wants to merge 1 commit into
HttpClientModule & HttpClientTestingModule.#58777JeanMeche wants to merge 1 commit into
Conversation
angular-robot
Bot
added
the
area: migrations
JeanMeche
added
the
target: lts
JeanMeche
force-pushed
the
fix/htttp-provider-migrations
branch
from
November 20, 2024 15:15
623e155 to
ac0e16e
Compare
JeanMeche
changed the title
HttpClientModule & HttpClientTestingModule.
JeanMeche
marked this pull request as ready for review
November 20, 2024 20:08
devversion
previously approved these changes
Nov 21, 2024
JeanMeche
force-pushed
the
fix/htttp-provider-migrations
branch
from
November 21, 2024 12:37
ac0e16e to
33ba20e
Compare
… & HttpClientTestingModule. While having both `HttpClientModule` & `HttpClientTestingModule` serves no real purpose (`HttpClientTestingModule` imports `HttpClientModule`), some code bases can have those 2 together and the migration can be quite breaking. fixes angular#58536
JeanMeche
force-pushed
the
fix/htttp-provider-migrations
branch
from
November 21, 2024 13:03
33ba20e to
0e162d9
Compare
devversion
approved these changes
Nov 21, 2024
1 task
thePunderWoman
added
action: merge
Contributor
|
This PR was merged into the repository by commit 06d70a2. The changes were merged into the following branches: 18.2.x |
|
what that mean, that now in tests we can just provide |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While having both
HttpClientModule&HttpClientTestingModuleserves no real purpose (HttpClientTestingModuleimportsHttpClientModule), some code bases can have those 2 together and the migration can be quite breaking without this fix.fixes #58536