fix(compiler): fix :host parsing in pseudo-selectors - #58554
Closed
GeorgySerga wants to merge 1 commit into
Closed
GeorgySerga wants to merge 1 commit into
GeorgySerga wants to merge 1 commit into
Conversation
fix several use-cases where `:host` was used in or around pseudo-selectors - `:host` followed by a comma inside pseudo-selectors - `:host` outside of pseudo-selectors when another `:host` is present within see tests for examples
angular-robot
Bot
added
the
area: compiler
Contributor
Author
|
Closing, #58557 builds on changes here |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix several use-cases where
:hostwas used in or around pseudo-selectors:hostfollowed by a comma inside pseudo-selectors:hostoutside of pseudo-selectors when another:hostis present within see tests for examplesPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Look for added tests. Mainly
:has(:host, .foo)isn't parsed correctly (the comma after foo was recognized as a selector;:host:has(.foo.host)isn't scoped correctly (added[content]scoping).Issue Number: 18.2.8 breaks multiple selectors in
:noton:host#58226Fixing issues outlined in this comment, doesn't solve all of the problems mentioned, splitting PR's as fixes seem not relevant.
What is the new behavior?
Different
:hostcombinations around pseudo-selectors are parsed correctly.Does this PR introduce a breaking change?
Other information
This PR doesn't resolve the whole issue, but fixes a set of use-cases.