Skip to content

feat(http): promote withRequestsMadeViaParent to stable. - #58221

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:feat/promote-withRequestsMadeViaParent
Closed

JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:feat/promote-withRequestsMadeViaParent

Conversation

@JeanMeche

Copy link
Copy Markdown
Member

Introduced back in v15 by #47502, its usage with fix with #55652 for the FetchBackend which will become the default HttpBackend with #58212

@pullapprove
pullapprove Bot requested a review from AndrewKushnir October 16, 2024 13:14
@ngbot ngbot Bot removed this from the v19 Feature Freeze Candidates milestone Oct 16, 2024
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Oct 16, 2024
@devversion

Copy link
Copy Markdown
Member

FYI: There seems to be a typo in the commit message

Introduced back in v15 by angular#47502, its usage with fix with angular#55652 for the `FetchBackend` which will become the default `HttpBackend` with angular#58212
@JeanMeche
JeanMeche force-pushed the feat/promote-withRequestsMadeViaParent branch from 805052f to 057ddc3 Compare October 16, 2024 13:32
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 16, 2024

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 16, 2024
@AndrewKushnir

Copy link
Copy Markdown
Contributor

Caretaker note: no presubmit required, docs-only change.

@devversion devversion changed the title feat(http): promite withRequestsMadeViaParent to stable. feat(http): promote withRequestsMadeViaParent to stable. Oct 17, 2024
@devversion

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 4b9accd.

The changes were merged into the following branches: main

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants