feat(language-service): support converting to signal queries in VSCode extension - #58106
Closed
devversion wants to merge 4 commits into
Closed
devversion wants to merge 4 commits into
devversion wants to merge 4 commits into
Conversation
…migrate` This allows us to return extra properties along with `#migrate` replacements. Useful for language service integration or other integrations of Tsurge migrations in special runners.
devversion
marked this pull request as ready for review
October 7, 2024 12:31
…ing TCB information Whenever information is requested from the template checker right now, the shim is only ensured to be generated for the single file/component. This is slow in migrations where we don't want to collect diagnostics, but rather request information from the component state. This commit supports `OptimizeFor` in `checker#getTemplate`.
Instead of inspecting all types of property accesses, we can use a similar optimization we did for TS references— leveraging the list of known field names to minimize type checker calls.
devversion
force-pushed
the
lsp-queries
branch
from
October 7, 2024 13:30
5d389be to
7297bd6
Compare
…e extension This commit adds support for converting decorator queries to signal queries via the VSCode extension. Note that this is not fully finished as we still need to add better messaging when certain fields could not be migrated. In addition, it's worth noting that the migration is not as safe as the input migration because commonly query lists are passed around— this quickly can break the build— but is an acceptable trade-off for the work saved. A migration cannot be 100% correct in general; there are always edge-cases.
devversion
force-pushed
the
lsp-queries
branch
from
October 7, 2024 13:45
7297bd6 to
3c3cb0c
Compare
Member
Author
|
Caretaker note: Please include https://critique.corp.google.com/cl/683183773 into your sync. |
crisbeto
approved these changes
Oct 7, 2024
Member
Author
|
This PR was merged into the repository by commit bc83fc1. The changes were merged into the following branches: main |
devversion
added a commit
that referenced
this pull request
Oct 8, 2024
…ing TCB information (#58106) Whenever information is requested from the template checker right now, the shim is only ensured to be generated for the single file/component. This is slow in migrations where we don't want to collect diagnostics, but rather request information from the component state. This commit supports `OptimizeFor` in `checker#getTemplate`. PR Close #58106
devversion
added a commit
that referenced
this pull request
Oct 8, 2024
) Instead of inspecting all types of property accesses, we can use a similar optimization we did for TS references— leveraging the list of known field names to minimize type checker calls. PR Close #58106
devversion
added a commit
that referenced
this pull request
Oct 8, 2024
…e extension (#58106) This commit adds support for converting decorator queries to signal queries via the VSCode extension. Note that this is not fully finished as we still need to add better messaging when certain fields could not be migrated. In addition, it's worth noting that the migration is not as safe as the input migration because commonly query lists are passed around— this quickly can break the build— but is an acceptable trade-off for the work saved. A migration cannot be 100% correct in general; there are always edge-cases. PR Close #58106
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits