Skip to content

fix(core): Ensure the ViewContext is retained after closure minific… - #57903

Closed
atscott wants to merge 1 commit into
angular:mainfrom
atscott:nocollapse2
Closed

atscott wants to merge 1 commit into
angular:mainfrom
atscott:nocollapse2

Conversation

@atscott

@atscott atscott commented Sep 20, 2024 •

Copy link
Copy Markdown
Contributor

…ation

In order to survive closure minification correctly, static properties need to be annotated with @nocollapse.

For more history, see #28050

@atscott atscott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 20, 2024
@atscott
atscott requested a review from alxhub September 20, 2024 17:47
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Sep 20, 2024
@ngbot ngbot Bot added this to the Backlog milestone Sep 20, 2024
…ation

In order to survive closure minification correctly, static properties need to
be annotated with `@nocollapse`.

For more history, see angular#28050
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 20, 2024
@ngbot ngbot Bot modified the milestone: Backlog Sep 20, 2024
@atscott

atscott commented Sep 20, 2024

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit 950a554.

The changes were merged into the following branches: main

@atscott atscott closed this in 950a554 Sep 20, 2024
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants