Conversation
angular-robot
Bot
added
detected: feature
JeanMeche
force-pushed
the
feat/standalone-false
branch
from
September 3, 2024 16:56
ce14dde to
8d8674b
Compare
JeanMeche
marked this pull request as ready for review
September 3, 2024 16:56
JeanMeche
force-pushed
the
feat/standalone-false
branch
2 times, most recently
from
September 3, 2024 17:03
bcb37ba to
dd1cd74
Compare
ilirbeqirii
reviewed
Sep 3, 2024
thePunderWoman
approved these changes
Sep 3, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
Other than the reported comment about changing the exception message, this looks good.
JeanMeche
force-pushed
the
feat/standalone-false
branch
from
September 4, 2024 10:02
dd1cd74 to
f5976c9
Compare
JoostK
reviewed
Sep 4, 2024
Member
There was a problem hiding this comment.
Do we want/need this to work for import * as ng from '@angular/core'; @ng.Component() usages?
JeanMeche
force-pushed
the
feat/standalone-false
branch
6 times, most recently
from
September 5, 2024 17:42
f50d5da to
83beed1
Compare
With the framework enabling `standalone` by default (making module based an opt-in), the migration will migrate none-standalone existing components and add `standalone: false` to the decorator.
JeanMeche
force-pushed
the
feat/standalone-false
branch
from
September 5, 2024 17:50
83beed1 to
42fb8b9
Compare
AndrewKushnir
added
the
target: major
AndrewKushnir
approved these changes
Sep 6, 2024
AndrewKushnir
added
the
action: presubmit
Contributor
AndrewKushnir
added
action: merge
Contributor
|
This PR was merged into the repository by commit 6ea8e1e. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the framework enabling
standaloneby default (making module based an opt-in), the migration will migrate none-standalone existing components and addstandalone: falseto the decorator.The migration will also remove
standalone: trueproperties as they are now not necessary anymore