Conversation
… ResolveFn This commit updates the interface of `Resolve` to allow for `RedirectCommand`, as was done with `ResolveFn` in v18. fixes angular#57131 BREAKING CHANGE: The return type of the `Resolve` interface now includes `RedirectCommand`.
atscott
added
area: router
target: major
pullapprove
Bot
requested review from
alxhub,
pkozlowski-opensource and
thePunderWoman
August 8, 2024 16:00
angular-robot
Bot
added
the
detected: breaking change
thePunderWoman
approved these changes
Aug 8, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
LGTM
reviewed-for: public-api
AndrewKushnir
approved these changes
Aug 8, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api, fw-router
ArturShevts
approved these changes
Aug 12, 2024
Contributor
|
This PR was merged into the repository by commit 7436d31. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… ResolveFn
This commit updates the interface of
Resolveto allow forRedirectCommand, as was done withResolveFnin v18.fixes #57131
BREAKING CHANGE: The return type of the
Resolveinterface now includesRedirectCommand.