Conversation
…ked` extended diagnostic This commit addresses a performance bottleneck in the `interpolatedSignalNotInvoked` extended diagnostic by querying directive metadata instead of consulting the type-checker to determine if a property binding corresponds with an input. Fixes angular#57287
JoostK
added
area: performance
alxhub
approved these changes
Aug 7, 2024
alxhub
added
action: merge
devversion
approved these changes
Aug 7, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 7, 2024
…ked` extended diagnostic (#57291) This commit addresses a performance bottleneck in the `interpolatedSignalNotInvoked` extended diagnostic by querying directive metadata instead of consulting the type-checker to determine if a property binding corresponds with an input. Fixes #57287 PR Close #57291
Contributor
|
This PR was merged into the repository by commit 0b1dd39. The changes were merged into the following branches: main, 18.1.x |
JoostK
added a commit
to JoostK/angular
that referenced
this pull request
Aug 11, 2024
…voked` extended diagnostic A prior fix in angular#57291 has introduced the potential for false negatives, as the used directives that were checked can be present anywhere in the template, not necessarily on the current element that is being checked. Fixing this requires reshuffling the check's logic a bit, as the extended diagnostics infrastructure does not provide access to ancestor nodes, nor do the AST nodes themselves. The performance regression that was fixed in angular#57291 doesn't reappear with this change, although it may affect performance slightly as potentially more bindings may end up being checked.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ked` extended diagnostic
This commit addresses a performance bottleneck in the
interpolatedSignalNotInvokedextended diagnostic by querying directive metadata instead of consulting the type-checker to determine if a property binding corresponds with an input.Fixes #57287