Skip to content

feat(router): Add defaultQueryParamsHandling to router configuration - #57198

Closed
atscott wants to merge 2 commits into
angular:mainfrom
atscott:defaultQueryParams
Closed

feat(router): Add defaultQueryParamsHandling to router configuration#57198
atscott wants to merge 2 commits into
angular:mainfrom
atscott:defaultQueryParams

Conversation

@atscott

@atscott atscott commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

This commit adds an option to specify the default value for queryParamsHandling in Router.createUrlTree when another option is not specified (or is null|undefined).

resolves #12664

@atscott
feat(router): Add defaultQueryParamsHandling to router configuration
a8932b8 
This commit adds an option to specify the default value for
`queryParamsHandling` in `Router.createUrlTree` when another option is
not specified (or is `null|undefined`).

resolves angular#12664
@atscott atscott added the target: minor This PR is targeted for the next minor release label Jul 30, 2024
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: router labels Jul 30, 2024
@atscott atscott added feature Label used to distinguish feature request from other issues and removed detected: feature PR contains a feature commit labels Jul 30, 2024
@ngbot ngbot Bot added this to the Backlog milestone Jul 30, 2024
thePunderWoman
thePunderWoman approved these changes Jul 30, 2024
View reviewed changes

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Comment thread packages/router/src/router_config.ts
import {InjectionToken} from '@angular/core';

import {OnSameUrlNavigation} from './models';
import {OnSameUrlNavigation, QueryParamsHandling} from './models';

@thePunderWoman thePunderWoman Jul 30, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually there's also shipping to go along with the handling... maybe I'm mistaken.

@atscott atscott Jul 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't included in our logistics solution right now. Maybe open a feature request?

@pullapprove
pullapprove Bot requested a review from alxhub July 30, 2024 20:58
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Jul 31, 2024
AndrewKushnir
AndrewKushnir approved these changes Aug 1, 2024
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api, fw-router

Comment thread packages/router/test/create_url_tree.spec.ts Outdated
@atscott
atscott force-pushed the defaultQueryParams branch from c7e0a14 to 05d99cc Compare August 1, 2024 19:26
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2024
@atscott
atscott removed request for alxhub and dylhunn August 1, 2024 22:39
@thePunderWoman

thePunderWoman commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 6c76c91.

The changes were merged into the following branches: main

davayd
davayd reviewed Aug 5, 2024
View reviewed changes
Comment thread packages/router/test/create_url_tree.spec.ts
This was referenced Sep 4, 2024
Closed
Closed
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 4, 2024
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 5, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+1 more reviewer
@davayd davayd davayd left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit feature Label used to distinguish feature request from other issues target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Allow router configuration so that preserveQueryParams is true by default

4 participants

@atscott @thePunderWoman @davayd @AndrewKushnir