Conversation
…in tests This creates a private option that can be used internally while we migrate this to the default and only behavior. ~200 tests in TGP have errors that are being swallowed (console.log) and not causing the test to fail. We can first explicitly opt those out, flip the default internally, then "fix" them by adding expect...toThrow.
atscott
force-pushed
the
rethrowerrorsforzonetests
branch
from
July 29, 2024 21:44
b0bfa38 to
b422ac4
Compare
pkozlowski-opensource
approved these changes
Jul 30, 2024
atscott
added
action: merge
Contributor
Author
|
caretaker note: presubmit ran already before rebase. I reused the CL for the follow-up internal changes to make this the default so I can't rerun a new presubmit. If you'd like another presubmit to be safe, please kick off another one. |
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 30, 2024
…in tests (#57153) This creates a private option that can be used internally while we migrate this to the default and only behavior. ~200 tests in TGP have errors that are being swallowed (console.log) and not causing the test to fail. We can first explicitly opt those out, flip the default internally, then "fix" them by adding expect...toThrow. PR Close #57153
Contributor
|
This PR was merged into the repository by commit b3836c2. The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a private option that can be used internally while we
migrate this to the default and only behavior. ~200 tests in TGP have errors
that are being swallowed (console.log) and not causing the test to fail.
We can first explicitly opt those out, flip the default internally, then
"fix" them by adding expect...toThrow.