feat(core): introduce debugName optional arg to framework signal functions - #57073
AleksanderBodurri wants to merge 1 commit into
Conversation
pullapprove
Bot
added
the
requires: TGP
angular-robot
Bot
added
detected: feature
6d94bb9 to
ef5240b
Compare
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Thanks @AleksanderBodurri, this look great! A lot more places to update than I expected. 😅
I just have one question about ngDevMode usage and a few minor nits, but nothing too significant here.
| * @param options Additional options for the model. | ||
| */ | ||
| export function createModelSignal<T>(initialValue: T): ModelSignal<T> { | ||
| export function createModelSignal<T>(initialValue: T, opts?: ModelOptions): ModelSignal<T> { |
There was a problem hiding this comment.
ModelOptions's alias isn't used in the function. Should we narrow down the type here ?
70c8e84 to
8ce5039
Compare
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Generally this LGTM. For g3sync reasons you'll need to separate the changes to @angular/core/primitives code into a separate PR, plus there are a few topics to discuss on
There was a problem hiding this comment.
Should we not assign this only inngDevMode above? Also, we should conditionally assign only if options?.debugName is defined (otherwise we add an extra property to all nodes of this type, which has a high memory cost).
e96e1f7 to
3d7835b
Compare
pullapprove
Bot
removed
the
requires: TGP
53a0a0a to
a15259f
Compare
angular-robot
Bot
added
area: core
…tions Angular DevTools is working on developing signal debugging support. This commit is a step in the direction of making available debug information to the framework that will allow Angular DevTools to provide users with more accurate information regarding the usage of signals in their applications. Follow up PRs that will use this arg will: - Develop a typescript transform that will detect usages of signal functions and attempt to add a debugName without the user needing to specify one directly - Develop debug APIs for discovering signal graphs within Angular applications (using debugName as a way to label nodes on the graph)
a15259f to
48b42ee
Compare
angular-robot
Bot
added
area: core
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
thePunderWoman
left a comment
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
alxhub
added
the
merge: caretaker note
|
Caretaker: this is "green" in g3. |
|
This PR was merged into the repository by commit ec386e7. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
7 participants
Blocked by #57710
Angular DevTools is working on developing signal debugging support. This commit is a step in the direction of making available debug information to the framework that will allow Angular DevTools to provide users with more accurate information regarding the usage of signals in their applications.
Follow up PRs that will use this arg will: