Conversation
atscott
changed the title
bootstrapModule to configure NgZone in providersbootstrapModule to configure NgZone in providers
atscott
force-pushed
the
bootstrapModuleNgZoneInProviders
branch
from
July 19, 2024 23:09
9794ba1 to
63f2beb
Compare
atscott
force-pushed
the
bootstrapModuleNgZoneInProviders
branch
4 times, most recently
from
July 22, 2024 21:05
e14ee7c to
b795adc
Compare
This commit allows configuring `NgZone` through the providers for `bootstrapModule`. Prior to this change, developers had to configure `NgZone` in the `BootstrapOptions`.
…ion and bootstrapModule This commit de-duplicates the code for bootstrapping between `bootstrapApplication` and `bootstrapModule`. A majority of the bootstrap code was identical between the two, with some minor differences that can be handled with a function overload.
atscott
force-pushed
the
bootstrapModuleNgZoneInProviders
branch
from
July 22, 2024 21:15
b795adc to
77c46e9
Compare
atscott
marked this pull request as ready for review
July 23, 2024 15:17
Contributor
Author
…otstrapModule This commit adds the `ImagePerformanceWarning` to the common bootstrap code rather than only starting it when using `bootstrapApplication`.
atscott
force-pushed
the
bootstrapModuleNgZoneInProviders
branch
from
July 23, 2024 15:18
77c46e9 to
70985b8
Compare
It no longer requires ngZone: 'noop' because NgZone can be configured in providers
alxhub
approved these changes
Jul 26, 2024
bougwal
reviewed
Jul 27, 2024
|
|
||
| import {Injector} from '../di/injector'; | ||
| import {EnvironmentInjector} from '../di/r3_injector'; | ||
| import {EnvironmentInjector, R3Injector} from '../di/r3_injector'; |
There was a problem hiding this comment.
Q: Isn't this a leftover ? - I do not see where R3Injector is being used in this file
Suggested change
| import {EnvironmentInjector, R3Injector} from '../di/r3_injector'; | |
| import {EnvironmentInjector} from '../di/r3_injector'; |
thePunderWoman
pushed a commit
that referenced
this pull request
Jul 30, 2024
It no longer requires ngZone: 'noop' because NgZone can be configured in providers PR Close #57060
Contributor
|
This PR was merged into the repository by commit 8098945. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits