Conversation
angular-robot
Bot
added
detected: feature
atscott
marked this pull request as ready for review
August 1, 2024 21:32
pullapprove
Bot
requested review from
AndrewKushnir,
dylhunn and
pkozlowski-opensource
August 1, 2024 21:32
AndrewKushnir
approved these changes
Aug 4, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api, fw-router
thePunderWoman
approved these changes
Aug 5, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: fw-testing, public-api
This commit adds an input to `RouterOutlet` that allows developers to pass data from a parent component to the outlet components. Setting the `routerOutletData` input on `RouterOutlet` makes the value available to the child component injectors via the `ROUTER_OUTLET_DATA` token. This token uses a `Signal` type to allow updating the input value and propogating it to the token rather than needing to make the value static. resolves angular#46283
Contributor
|
This PR was merged into the repository by commit f271021. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an input to
RouterOutletthat allows developers to pass data from a parent component to the outlet components. Setting therouterOutletDatainput onRouterOutletmakes the value available to the child component injectors via theROUTER_OUTLET_DATAtoken. This token uses aSignaltype to allow updating the input value and propagating it to the token rather than needing to make the value static.resolves #46283