Skip to content

feat(common): add optional rounded transform support in cloudinary image loader #55364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devashishSarmah wants to merge 1 commit into from
Closed

feat(common): add optional rounded transform support in cloudinary image loader #55364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/common/src/directives/ng_optimized_image/image_loaders/cloudinary_loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,9 @@ function createCloudinaryUrl(path: string, config: ImageLoaderConfig) {
params += `,w_${config.width}`;
}

if (config.loaderParams?.['rounded']) {
params += `,r_max`;
}

return `${path}/image/upload/${params}/${config.src}`;
}
10 changes: 10 additions & 0 deletions packages/common/test/image_loaders/image_loader_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ describe('Built-in image directive loaders', () => {
expect(loader({src: '/img.png'})).toBe(`${path}/image/upload/f_auto,q_auto/img.png`);
});
});

describe('config validation', () => {
it('should add the r_max cloudinary transformation to the URL when the rounded option is provided', () => {
const path = 'https://res.cloudinary.com/mysite';
const loader = createCloudinaryLoader(path);
expect(loader({src: '/img.png', loaderParams: {rounded: true}})).toBe(
`${path}/image/upload/f_auto,q_auto,r_max/img.png`,
);
});
});
});

describe('ImageKit loader', () => {
Expand Down