Skip to content

feat(common): add optional rounded transform support in cloudinary image loader - #55364

Closed
devashishSarmah wants to merge 1 commit into
angular:mainfrom
devashishSarmah:image-loader-cloudinary-add-rounded-transform
Closed

feat(common): add optional rounded transform support in cloudinary image loader#55364
devashishSarmah wants to merge 1 commit into
angular:mainfrom
devashishSarmah:image-loader-cloudinary-add-rounded-transform

Conversation

@devashishSarmah

@devashishSarmah devashishSarmah commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, the cloudinary image loader doesn't support rounded transform

Issue Number: N/A

What is the new behavior?

Added a change which enables the users to add a prop called rounded to the existing ImageLoaderConfig.loaderParams prop.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from dylhunn April 16, 2024 15:27
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Apr 16, 2024
@pkozlowski-opensource pkozlowski-opensource added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2024
@ngbot ngbot Bot added this to the Backlog milestone Apr 16, 2024
@devashishSarmah
devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from ac6c240 to 3ed3fc4 Compare April 17, 2024 10:37
@JeanMeche

JeanMeche commented Sep 20, 2024

Copy link
Copy Markdown
Member

Could you add a corresponding unit test, thank you.

@pullapprove
pullapprove Bot requested a review from thePunderWoman October 9, 2024 19:21
@devashishSarmah

devashishSarmah commented Oct 9, 2024

Copy link
Copy Markdown
Contributor Author

Hi, The unit test has been added.

@thePunderWoman
thePunderWoman requested review from AndrewKushnir and removed request for dylhunn and thePunderWoman October 9, 2024 19:24
@devashishSarmah
devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from b05faac to 99b5785 Compare October 9, 2024 19:28
AndrewKushnir
AndrewKushnir approved these changes Oct 11, 2024
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devashishSarmah thanks for the improvement!

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Oct 11, 2024
@AndrewKushnir

AndrewKushnir commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Presubmit.

@devashishSarmah

devashishSarmah commented Oct 13, 2024

Copy link
Copy Markdown
Contributor Author

Hi @AndrewKushnir, The linting has failed due to the merge commits "Merge branch 'angular:main' into image-loader-cloudinary-add-rounded-transform". What can be done here?

@JeanMeche

JeanMeche commented Oct 14, 2024

Copy link
Copy Markdown
Member

You while need to rebase your PR, drop the merge commits and squash everything into a single commit. We'd like this change to be a single commit. Thank you.

@devashishSarmah
feat(common): add optional rounded transform support in cloudinary im…
a4a5a52 
…age loader

Currently, the cloudinary image loader doesn't support rounded transform.
Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams`

test(common): add test case for cloudinary loader rounded option

add test case for the rounded transform option of cloudinary loader
@devashishSarmah
devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from b1c57ab to a4a5a52 Compare October 14, 2024 05:20
@angular-robot
angular-robot Bot requested a review from AndrewKushnir October 14, 2024 05:20
@devashishSarmah

devashishSarmah commented Oct 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @JeanMeche, I have merged all my commits into a single one.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Oct 22, 2024
@AndrewKushnir

AndrewKushnir commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 24c6373.

The changes were merged into the following branches: main

@devashishSarmah
devashishSarmah deleted the image-loader-cloudinary-add-rounded-transform branch October 24, 2024 05:16
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 24, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@devashishSarmah @JeanMeche @AndrewKushnir @pkozlowski-opensource