Skip to content

fix(core): Re-assign error codes to be within core bounds (<1000) #53455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danieljancar wants to merge 1 commit into from
Closed

fix(core): Re-assign error codes to be within core bounds (<1000) #53455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions goldens/public-api/core/errors.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ export const enum RuntimeErrorCode {
// (undocumented)
REQUIRED_QUERY_NO_VALUE = -951,
// (undocumented)
RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 1000,
RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 980,
// (undocumented)
RUNTIME_DEPS_ORPHAN_COMPONENT = 1001,
RUNTIME_DEPS_ORPHAN_COMPONENT = 981,
// (undocumented)
SIGNAL_WRITE_FROM_ILLEGAL_CONTEXT = 600,
// (undocumented)
Expand Down
6 changes: 4 additions & 2 deletions packages/core/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,10 @@ export const enum RuntimeErrorCode {
LOOP_TRACK_RECREATE = -956,

// Runtime dependency tracker errors
RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 1000,
RUNTIME_DEPS_ORPHAN_COMPONENT = 1001,
RUNTIME_DEPS_INVALID_IMPORTED_TYPE = 980,
RUNTIME_DEPS_ORPHAN_COMPONENT = 981,

// Upper bounds for core runtime errors is 999
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/linker/integration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,7 @@ describe('integration tests', function () {

TestBed.configureTestingModule({declarations: [MainComp]});
expect(() => TestBed.createComponent(MainComp)).toThrowError(
/^NG01001: Orphan component found\! Trying to render the component MainComp \(at test\.ts:11\) without first loading the NgModule that declares it/,
/^NG0981: Orphan component found\! Trying to render the component MainComp \(at test\.ts:11\) without first loading the NgModule that declares it/,
);
});

Expand Down