Skip to content

feat(forms): add ability to clear a FormRecord - #50750

Closed
EmmanuelRoux wants to merge 0 commit into
angular:mainfrom
EmmanuelRoux:formrecord-clear
Closed

feat(forms): add ability to clear a FormRecord#50750
EmmanuelRoux wants to merge 0 commit into
angular:mainfrom
EmmanuelRoux:formrecord-clear

Conversation

@EmmanuelRoux

@EmmanuelRoux EmmanuelRoux commented Jun 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fixes #50748 and #50751

What is the new behavior?

New method FormRecord.clearControls() is available.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from dylhunn June 17, 2023 18:23
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Jun 17, 2023
@EmmanuelRoux EmmanuelRoux mentioned this pull request Jun 17, 2023
Open
@EmmanuelRoux
EmmanuelRoux force-pushed the formrecord-clear branch 3 times, most recently from ce2375e to 54abda7 Compare June 17, 2023 19:07
@EmmanuelRoux

EmmanuelRoux commented Jun 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This PR needs #50752 to be fixed first (tests will fail otherwise).

#50752 merged with this PR

@JeanMeche JeanMeche added state: blocked area: forms forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray. labels Jun 17, 2023
@ngbot ngbot Bot added this to the Backlog milestone Jun 17, 2023
@EmmanuelRoux EmmanuelRoux mentioned this pull request Aug 29, 2023
Closed
5 of 14 tasks
@EmmanuelRoux

EmmanuelRoux commented Oct 20, 2023

Copy link
Copy Markdown
Contributor Author

Any update on this PR please ?

@lazarljubenovic

lazarljubenovic commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

What's blocking this?

JeanMeche
JeanMeche reviewed May 17, 2024
View reviewed changes
Comment thread packages/forms/src/model/form_group.ts Outdated
@JeanMeche
JeanMeche force-pushed the formrecord-clear branch 5 times, most recently from 5ec23e9 to 656e5b0 Compare May 17, 2024 19:16
@JeanMeche

JeanMeche commented May 17, 2024

Copy link
Copy Markdown
Member

Let me help to see where we can go with this change.

JeanMeche
JeanMeche approved these changes May 17, 2024
View reviewed changes

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary tests against the Google codebase came back green.

@dylhunn

dylhunn commented May 28, 2024

Copy link
Copy Markdown
Contributor

Running a TGP (googler link).

@dylhunn

dylhunn commented May 28, 2024

Copy link
Copy Markdown
Contributor

@EmmanuelRoux Would you mind rebasing this on main?

@angular-robot angular-robot Bot removed the detected: feature PR contains a feature commit label May 28, 2024
@EmmanuelRoux

EmmanuelRoux commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

@dylhunn done 👍

AndrewKushnir pushed a commit that referenced this pull request Oct 22, 2024
@EmmanuelRoux @AndrewKushnir
test(forms): add unit test (#50750)
b0c4c1f 
Add unit test for statusChange events

PR Close #50750
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "test(forms): add unit test (angular#50750)"
f02511e 
This reverts commit b0c4c1f.
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "feat(forms): add ability to clear a FormRecord (angular#50750)"
5adfc63 
This reverts commit 3e7d724.
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "fix(forms): fix FormRecord type inference (angular#50750)"
eaa4062 
This reverts commit 18b6f33.
@AndrewKushnir AndrewKushnir mentioned this pull request Oct 22, 2024
Closed
AndrewKushnir added a commit that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "test(forms): add unit test (#50750)" (#58315)
a5b0394 
This reverts commit b0c4c1f.

PR Close #58315
AndrewKushnir added a commit that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "feat(forms): add ability to clear a FormRecord (#50750)" (#58315
79d9be3 
)

This reverts commit 3e7d724.

PR Close #58315
AndrewKushnir added a commit that referenced this pull request Oct 22, 2024
@AndrewKushnir
Revert "fix(forms): fix FormRecord type inference (#50750)" (#58315)
1f45338 
This reverts commit 18b6f33.

PR Close #58315
@AndrewKushnir

AndrewKushnir commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

FYI, reopening this PR due to a breakage in Google's codebase (typing-related). Reverted via #58315, the change will need a global presubmit (TGP).

Next step is for the Angular team to run TGP and investigate failures.

@AndrewKushnir AndrewKushnir reopened this Oct 22, 2024
@AndrewKushnir AndrewKushnir added state: blocked action: global presubmit The PR is in need of a google3 global presubmit and removed action: merge The PR is ready for merge by the caretaker labels Oct 22, 2024
@Nallebeorn

Nallebeorn commented Dec 3, 2024

Copy link
Copy Markdown

The changelog mentions this new function (https://github.com/angular/angular/blob/main/CHANGELOG.md#forms-1) for v19.0.0

There's no mention in the changelog of it being reverted so this is a bit misleading, and it's unclear which versions (if any) shipped with it before being reverted.

@JeanMeche

JeanMeche commented Dec 3, 2024

Copy link
Copy Markdown
Member

@Nallebeorn The feature was indeed un-shipped, we'll update the changelog.

@JeanMeche JeanMeche closed this Mar 28, 2025
@angular-robot angular-robot Bot removed the detected: feature PR contains a feature commit label Mar 28, 2025
@JeanMeche

JeanMeche commented Mar 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The rebase didn't go as expected, can you cherry pick your 3 commits (visible here https://github.com/EmmanuelRoux/angular/commits/7c707ed6f5) so we can reopen the PR.

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Apr 28, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes
@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes
@alxhub alxhub alxhub approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+1 more reviewer
@dylhunn dylhunn dylhunn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: global presubmit The PR is in need of a google3 global presubmit area: forms forms: Controls API Issues related to AbstractControl, FormControl, FormGroup, FormArray. state: blocked target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

v19.1 candidates

Development

Successfully merging this pull request may close these issues.

Add .clear() to remove all member controls of FormGroup|FormRecord

8 participants

@EmmanuelRoux @lazarljubenovic @JeanMeche @dylhunn @AndrewKushnir @Nallebeorn @pkozlowski-opensource @alxhub