Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 27, 2026

  1. fix(sentinel): re-elect primary on failover between already-known nod… 

    …es (#3131)

SwitchPrimary only reconfigured when the new primary was an unknown
endpoint. On an in-place failover (old master demoted, replica promoted),
the new master is already in `servers`, so it no-op'd and the client kept
writing to the demoted node until restart.

Reconfigure with reconfigureAll:true when a known primary's cached role is
stale, so connected nodes re-read their role before re-election. Also move
the switch reconfigure out of the sentinelConnectionChildren lock.

Refs #1891
    @rebaseandpanic
    rebaseandpanic authored Jul 27, 2026
    Configuration menu
    Copy the full SHA
    9689f02 View commit details
    Browse the repository at this point in the history
Loading