Skip to content

Add test_concurrent_futures to FLAKY_MP_TESTS#7502

Open
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:add-more-to-flaky-mp
Open

Add test_concurrent_futures to FLAKY_MP_TESTS#7502
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:add-more-to-flaky-mp

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai bot
Loading

See https://github.com/RustPython/RustPython/actions/runs/23490603823/job/68357496635?pr=7501#logs

Summary by CodeRabbit

  • Chores
    • Updated CI workflow test execution configuration to improve handling of tests that may be unreliable under parallel execution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 73fd38a1-b5a5-43b6-981e-30625c2f876b

📥 Commits

Reviewing files that changed from the base of the PR and between 82432be and da09f25.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

The CI workflow configuration is updated to include test_concurrent_futures in the FLAKY_MP_TESTS list, which designates tests that require single-process execution due to flakiness when run in parallel.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yaml		 Added test_concurrent_futures to the FLAKY_MP_TESTS list, affecting which tests are excluded from parallelized runs and included in dedicated single-process test jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A test joins the flaky crew,
Running solo through and through,
Concurrent futures now take their place,
Single-threaded, steady pace! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding test_concurrent_futures to the FLAKY_MP_TESTS list, which aligns perfectly with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ShaharNaveh