Skip to content

Resolve shellcheck warning on ci.yaml#7501

Merged
youknowone merged 8 commits intoRustPython:mainfrom
ShaharNaveh:actionlint-shellcheck-ci-quote
Mar 25, 2026
Merged

Resolve shellcheck warning on ci.yaml#7501
youknowone merged 8 commits intoRustPython:mainfrom
ShaharNaveh:actionlint-shellcheck-ci-quote

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Improved CI reliability by making shell argument handling and exit-code checks more robust.
    • Made test-loop invocation safer to ensure selected tests are respected and avoid shell-parsing issues.
    • Ensured WASM test runner uses a quoted working directory to prevent path-related failures and improve cross-platform stability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026 •
edited
Loading

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

CI workflow .github/workflows/ci.yaml updated for safer shell handling: quoted outputs and arguments, switched env-polluting-tests iteration to a line-based read loop, quote-wrapped numeric exit comparisons, and quoted $(pwd) for wasmer run --dir.

Changes

Cohort / File(s) Summary
CI workflow
./.github/workflows/ci.yaml		 Shell-hardening edits: append cores to "$GITHUB_OUTPUT"; build TESTS from matrix.env_polluting_tests and iterate with while IFS= read -r thing; do ... done <<< "$TESTS"; pass test entries as -v "${thing}"; use quoted numeric comparisons ("${exit_code}"); quote $(pwd) for wasmer run --dir in wasm-wasi steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐇 I hopped through YAML late at night,
Quoted each var to set things right.
Tests now read lines tidy and neat,
Wasmer finds home with quoted feet,
CI hums on—my whiskers bright.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: resolving shellcheck warnings in the ci.yaml workflow file by improving shell quoting and variable handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2026
View reviewed changes
@ShaharNaveh ShaharNaveh force-pushed the actionlint-shellcheck-ci-quote branch from 7b2ea11 to 423afb1 Compare March 24, 2026 14:00
@youknowone youknowone merged commit 20c6505 into RustPython:main Mar 25, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone