fix(android): reapply tintColor when Image src changes#11145
Open
owenthcarey wants to merge 1 commit intoNativeScript:mainfrom
Open
fix(android): reapply tintColor when Image src changes#11145owenthcarey wants to merge 1 commit intoNativeScript:mainfrom
owenthcarey wants to merge 1 commit intoNativeScript:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 09312a7
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, ColorFilter is applied to the Drawable, not the ImageView itself. When src changes dynamically (e.g. via binding), the new drawable replaces the old one and the tint is lost. This differs from iOS, where tintColor is a view-level property that persists across image changes.
This adds
_reapplyTintColor()to the Android Image implementation and calls it from both code paths that load a new image:onImageLoaded-- for images loaded natively via setUri (file/resource paths)[imageSourceProperty.setNative]-- for images set viasetImageBitmap(font icons, data URIs, ImageSource/ImageAsset)