Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Booklooker.de.xml, fix #15866#15963

Merged
Bisaloo merged 3 commits intoEFForg:masterfrom
cschanaj:booklooker.de
Jun 30, 2018
Merged

Update Booklooker.de.xml, fix #15866#15963
Bisaloo merged 3 commits intoEFForg:masterfrom
cschanaj:booklooker.de

Conversation

@cschanaj
Copy link
Copy Markdown
Collaborator

No description provided.

<target host="www.booklooker.de" />
<target host="api.booklooker.de" />
<target host="bms.booklooker.de" />
<target host="dev.booklooker.de" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target has a different behaviour over HTTP and HTTPS. Plus, we don't have a working test url. Given we had issues recently with securing dev subdomains, I'd rather not add it.

<target host="bms.booklooker.de" />
<target host="dev.booklooker.de" />
<target host="download.booklooker.de" />
<target host="falco.booklooker.de" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refused over HTTP and 403 over HTTPS. I'm not sure we should add it.

<target host="api.booklooker.de" />
<target host="bms.booklooker.de" />
<target host="dev.booklooker.de" />
<target host="download.booklooker.de" />
Copy link
Copy Markdown
Collaborator

@Bisaloo Bisaloo Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a test url here

<target host="dev.booklooker.de" />
<target host="download.booklooker.de" />
<target host="falco.booklooker.de" />
<target host="images.booklooker.de" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<target host="download.booklooker.de" />
<target host="falco.booklooker.de" />
<target host="images.booklooker.de" />
<target host="images2.booklooker.de" />
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as falco and dev. I'm open to discussion but I'm inclined to remove it.

@Bisaloo Bisaloo self-assigned this Jun 29, 2018
@cschanaj cschanaj closed this Jun 30, 2018
@cschanaj cschanaj reopened this Jun 30, 2018
@cschanaj
Copy link
Copy Markdown
Collaborator Author

@Bisaloo I have removed the hosts with inconsistent behavior over HTTP and HTTPS, but I cannot find a test url for download from a quick google search. I shall remove that as well depending on your opinion. thanks!

@Bisaloo
Copy link
Copy Markdown
Collaborator

Bisaloo commented Jun 30, 2018

There is a 301 redirect to download so let's keep it.

@Bisaloo
Copy link
Copy Markdown
Collaborator

Bisaloo commented Jun 30, 2018

stats should be removed as well

@Bisaloo Bisaloo merged commit e19fc3b into EFForg:master Jun 30, 2018
@Bisaloo Bisaloo removed their assignment Jun 30, 2018
@cschanaj cschanaj deleted the booklooker.de branch June 30, 2018 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants