Open
Conversation
Member
vjik
commented
Apr 18, 2026
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
============================================
- Coverage 98.51% 98.48% -0.03%
+ Complexity 354 350 -4
============================================
Files 46 45 -1
Lines 942 926 -16
============================================
- Hits 928 912 -16
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the PushRequest abstraction from the push middleware pipeline, shifting the push middleware/handler contracts to operate directly on MessageInterface and updating the queue push flow and tests accordingly.
Changes:
- Replace
PushRequest-based push middleware/handler APIs withMessageInterface-based APIs. - Update
Queue::push()andAdapterPushHandlerto push messages directly via a fixed adapter instance. - Refactor unit/integration tests to use
MessageInterfaceand removePushRequest-specific tests.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Queue.php |
Updates push flow to dispatch MessageInterface and constructs AdapterPushHandler with the queue’s adapter. |
src/Middleware/Push/PushRequest.php |
Removes the PushRequest value object. |
src/Middleware/Push/PushMiddlewareDispatcher.php |
Changes dispatcher to accept/return MessageInterface. |
src/Middleware/Push/MiddlewarePushStack.php |
Updates stack handler signature to accept/return MessageInterface. |
src/Middleware/Push/MiddlewarePushInterface.php |
Changes middleware contract to processPush(MessageInterface, ...). |
src/Middleware/Push/MessageHandlerPushInterface.php |
Changes handler contract to handlePush(MessageInterface): MessageInterface. |
src/Middleware/Push/MiddlewareFactoryPush.php |
Updates callable wrapping/invocation to pass message + handler and expect MessageInterface. |
src/Middleware/Push/AdapterPushHandler.php |
Refactors handler to push via injected adapter and return the pushed message. |
src/Middleware/Push/Implementation/IdMiddleware.php |
Updates middleware implementation to work directly with MessageInterface. |
tests/Unit/Middleware/Push/Support/TestMiddleware.php |
Updates test middleware to new push middleware signature. |
tests/Unit/Middleware/Push/Support/TestCallableMiddleware.php |
Updates callable middleware signature to accept/return MessageInterface. |
tests/Unit/Middleware/Push/PushRequestTest.php |
Removes PushRequest immutability test. |
tests/Unit/Middleware/Push/MiddlewareFactoryTest.php |
Updates factory tests to assert message-based middleware behavior. |
tests/Unit/Middleware/Push/MiddlewareDispatcherTest.php |
Updates dispatcher tests to message-based pipeline behavior. |
tests/Unit/Middleware/Push/Implementation/IdMiddlewareTest.php |
Updates IdMiddleware tests to message-based inputs/outputs. |
tests/Unit/Middleware/Push/AdapterPushHandlerTest.php |
Updates handler test to construct handler with adapter and push messages directly. |
tests/Integration/Support/TestMiddleware.php |
Updates integration test middleware to new push signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.