test(harness): isolate source-preparation Node fixture - #309
Open
yailPeralta wants to merge 1 commit into
Open
yailPeralta wants to merge 1 commit into
yailPeralta wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #103
Chain linkage only: this source-test prerequisite does not complete #103 independently.
PR Type
type:chore)Summary
Changes
scripts/issue-103/node-fixture.mjsscripts/issue-103/node-fixture.test.mjsscripts/issue-103/prepared-source.test.mjspatches/deepseek-harness/issue-103/NOTES.mdChain Context
Immediate predecessor: #308,
test/103-pinned-source-acquisition,379c7a43795466a171eb5b4a9c00320c0ef0b008. Scope: 351 additions +2 deletions =353, including both complete new files (126+192 lines); no exception.Start: #308's verified exact-pin acquisition and source inspector. End: public reproducible isolated tool-copy fixture plus real source-CLI integration. This reconciles the preserved fixture without carrying the Git diagnostics/test twice; those belong to #308.
Two owners remain intentional: the fixture owns its copied payload and direct-child HOME/TMP/cache; the parent claims a separate canonical source work root. Cleanup awaits fixture disposal before independently removing source work. Existing provisioning may cache under its own work/private/tmp; trusted Git keeps HOME/XDG at
/nonexistentand omits temporary variables. This is not a universal descendant sandbox or cache-disabling claim.Deferred/out of scope: complete private-runtime admission, command runner, dependency/host/MCP compatibility, cumulative Linux/macOS CI, package publication, default repin, unrelated dependency upgrades, GUI changes and protected AST apply. The trusted installed payload is copied, not newly authenticated as a distribution. Shared tool ancestry remains unchanged.
Test Plan
ecf59cbe230920ad93074cc8376e6f5b23a8166c, with Node22.13.0 and Node24 matrices green; no reruns.NODE_OPTIONS='' NODE_DISABLE_COMPILE_CACHE=1 node --test scripts/issue-103/node-fixture.test.mjs scripts/issue-103/acquisition.test.mjs scripts/issue-103/setup.test.mjs scripts/issue-103/prepared-source.test.mjsHistorical cache RED/GREEN and failed/interrupted unrestricted-clone evidence remain historical. Current verification does not relabel those outcomes or claim host compatibility.
Contributor Checklist
type:chore.ecf59cbe230920ad93074cc8376e6f5b23a8166c, without coauthor trailers.Rollback removes this four-file fixture/integration unit only. #308's acquisition/Git error handling, source-readmission invariants, retained patches and shared process/package-manager owners remain unchanged. Keep #296 draft/no-merge; no aggregate integration approval is implied.