Skip to content

Simplify version check - #693

Closed
twose wants to merge 1 commit into
xdebug:masterfrom
twose:patch-1
Closed

twose wants to merge 1 commit into
xdebug:masterfrom
twose:patch-1

Conversation

@twose

@twose twose commented Nov 24, 2020

Copy link
Copy Markdown

No description provided.

@derickr

derickr commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

I'm closing this out, as the original version is more portable. In the past I used || which caused issues.

@derickr derickr closed this Nov 28, 2020
@twose

twose commented Dec 4, 2020

Copy link
Copy Markdown
Author

@derickr Thank you for your reply.
Before pulling this request, I also considered whether there are some unknown reasons, then I checked php.m4 and m4 files of other extensions, and I found that || was widely used... so, I am still confused about this.

@twose
twose deleted the patch-1 branch December 4, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants