Skip to content

fix: Do not display error dialog on failed eval - #561

Merged
zobo merged 2 commits into
nextfrom
fix/eval-errors
May 6, 2021
Merged

fix: Do not display error dialog on failed eval#561
zobo merged 2 commits into
nextfrom
fix/eval-errors

Conversation

@zobo

@zobo zobo commented May 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@zobo

zobo commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

Fixes #557

@zobo
zobo changed the base branch from main to next May 6, 2021 13:02
@zobo zobo self-assigned this May 6, 2021
@zobo zobo linked an issue May 6, 2021 that may be closed by this pull request
@zobo
zobo merged commit 9d5cf60 into next May 6, 2021
@zobo
zobo deleted the fix/eval-errors branch May 6, 2021 13:09
zobo added a commit that referenced this pull request May 6, 2021
* fix: Eval errors should not be returned with sendErrorResponse to prevent showing the error dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable error evaluating code toast

1 participant