Skip to content

fix: Detect IDE path format for convertDebuggerPathToClient - #525

Merged
zobo merged 1 commit into
mainfrom
detect-client-path
Mar 23, 2021
Merged

fix: Detect IDE path format for convertDebuggerPathToClient#525
zobo merged 1 commit into
mainfrom
detect-client-path

Conversation

@zobo

@zobo zobo commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

Try to detect format of client (IDE) and debugger (Xdebug) path format and explicitly use that instance of path class.

@codecov-io

codecov-io commented Mar 16, 2021

Copy link
Copy Markdown

Codecov Report

Merging #525 (ab2e368) into main (c18654d) will increase coverage by 0.03%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   66.69%   66.72%   +0.03%     
==========================================
  Files           6        6              
  Lines        1075     1079       +4     
  Branches      170      167       -3     
==========================================
+ Hits          717      720       +3     
- Misses        358      359       +1     
Impacted Files Coverage Δ
src/test/paths.ts 0.00% <0.00%> (ø)
src/paths.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18654d...ab2e368. Read the comment docs.

@zobo

zobo commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

This PR also incorporates #365.

@zobo
zobo merged commit f2a0dce into main Mar 23, 2021
@zobo
zobo deleted the detect-client-path branch March 23, 2021 21:28
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.14.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants