feat: Add support for Logpoints - #343
Conversation
augustocdias
changed the title
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
- Coverage 70.11% 70.1% -0.02%
=========================================
Files 5 6 +1
Lines 1014 1047 +33
Branches 161 169 +8
=========================================
+ Hits 711 734 +23
- Misses 303 313 +10
Continue to review full report at Codecov.
|
|
Any updates ? |
|
@qkdreyer I'm just using a local generated version of it instead of this because @felixfbecker seems to not maitain this repo anymore... |
|
Hello @augustocdias. Are you willing to rebase this? I'll have a fresh look at it and see if it can be merged. |
|
Done @zobo |
|
Is it only the tests that are missing? The feature is implemented? |
|
Hi! No, it's not about the tests. I am currently working on a large refactor on how the extension works with debug sessions (here #517). This has also a lot to do with breakpoints and logpoints. That's the reason I was avoiding merging this PR, although it could already go in. |
|
Oh! That's great to hear! I was thinking I could try working on the tests if it was only that missing. I can't wait to see the new version 😁 |
|
I did a merge/rebase and changed parts of how the logpoint class is integrated into the main phpDebug class. Will create a new release soon. |
feat: adding types for string-replace-async library feat: linting and prettifying feat: adding tests for logpoint class feat: fixing formatting feat: fixing doc for attribute
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Added support to logpoints. I have very limited knowledge about XDebug protocol, but I believe it does not support anything like the logpoint feature from VSCode.
So I thought about doing the following:
closes #258