feat: Add support for listening to a specific network interface if needed. - #289
feat: Add support for listening to a specific network interface if needed.#289mscharley wants to merge 1 commit into
Conversation
a768b4b to
e60558b
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 69.35% 69.41% +0.06%
==========================================
Files 5 5
Lines 992 994 +2
Branches 161 161
==========================================
+ Hits 688 690 +2
Misses 304 304
Continue to review full report at Codecov.
|
| #### Supported launch.json settings: | ||
|
|
||
| - `request`: Always `"launch"` | ||
| - `bind`: The address to bind to when listening for XDebug (default: all IPv6 connections if available, else all IPv4 connections) |
There was a problem hiding this comment.
I find this name a bit confusing. The argument to server.listen() is named hostname. Could we name it that?
There was a problem hiding this comment.
We can, I kind of find hostname confusing too in this context - it sounds like the name of the host that XDebug is connecting from. I've seen it named bind in other applications so that's why I used that name here. I think hostname makes sense in the context of a call to server.listen() but in the context of a configuration for this module it's ambiguous.
| "bind": { | ||
| "type": "string", | ||
| "description": "Address to bind to when listening for XDebug", | ||
| "default": "::" |
There was a problem hiding this comment.
Ideally this would default to null if possible, but not familiar with VS Code plugins to know if that is or not.
2 participants
This is my attempt at fixing #288