Skip to content

created Contributing.md #31

Merged
satwikkansal merged 2 commits into
wtfpython-web:masterfrom
Pallavi024:development
Aug 23, 2018
Merged

created Contributing.md #31
satwikkansal merged 2 commits into
wtfpython-web:masterfrom
Pallavi024:development

Conversation

@Pallavi024
Copy link
Copy Markdown
Contributor

NOTE:

  • Please fill out the template below

    • Did you read the instructions in the WORKFLOW ?

    • Is your Python code styled according to the PEP8 code style convention as mentioned here ?

    • Have you run the tests ?

    • Have you followed commit guidelines as mentioned here ?

@realslimshanky
Copy link
Copy Markdown

@Pallavi024 please squash your commits.

@Pallavi024
Copy link
Copy Markdown
Contributor Author

@realslimshanky I have squashed my commits...please take a look at it 😄

Comment thread Contributing.md Outdated
@@ -0,0 +1,141 @@

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a heading here like 'Contribution Guide - WTF'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@realslimshanky I apologise for the delay.I have made the required changes

Comment thread Contributing.md Outdated

$ git branch

Your current branch will have an asterisk (*) next to it. Ensure that there is no asterisk next to the master branch.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This asterisk should be escaped. It is making all the trailing text in Italics style.

Comment thread Contributing.md Outdated
@@ -0,0 +1,141 @@
# Contribution Guide -WTF
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space around -

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also WTFpython contribution guide sounds better to me.

Copy link
Copy Markdown

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satwikkansal satwikkansal merged commit 0ee267c into wtfpython-web:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants