Created pull request template#23
Merged
Merged
Conversation
|
|
||
| ## Did you read the instructions in the [WORKFLOW](https://github.com/wtfpython-web/wtfpython-web/wiki/Workflow) ? | ||
|
|
||
| > Y/N |
Contributor
There was a problem hiding this comment.
We can have checkboxes instead of Y/N, much cleaner imo
something like
- Did you read the instructions in the WORKFLOW
|
|
||
| > Y/N | ||
|
|
||
| ## Is your Python code styled according to the PEP8 code style convention ? |
Contributor
There was a problem hiding this comment.
Add a link to PEP8 guide
|
|
||
| ## Have you run the tests ? | ||
|
|
||
| >Y/N No newline at end of file |
Contributor
There was a problem hiding this comment.
Add another task in the template,
Have you followed commit guidelines at https://github.com/wtfpython-web/wtfpython-web/wiki/Commit-Guidelines
Also, make sure that you follow it too in your PR :)
Contributor
|
Nice work @Pallavi024, merged! 🎉 |
Contributor
|
Ideally, there should be only one commit for one atomic change, it's not a good practice to bloat codebase with a lot of commits. I squashed your commits into one before merge. You can do that on your own from the next time :) |
Contributor
Author
|
Ya sure, I'll do that from next time.Actually I'm contributing for the
first time but from next time i will take care : )
… You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae3EupiqAUo6DQ3i_1cUzKnouz_k1duuks5uBIrSgaJpZM4U4bjE>
.
|
Pallavi024
added a commit
to Pallavi024/wtfpython-web
that referenced
this pull request
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.