Skip to content
This repository was archived by the owner on Jun 11, 2019. It is now read-only.

stretch package names, gnupg is PECL not core - #24

Merged
jcshort merged 1 commit into
masterfrom
stretch
Aug 8, 2018
Merged

jcshort merged 1 commit into
masterfrom
stretch

Conversation

@jcshort

@jcshort jcshort commented Aug 8, 2018 •

Copy link
Copy Markdown
Member

upstream php-fpm images are no longer jessie, so we need stretch package names for ICU, PNG, and XSLT libs.

I done goofed in #21:

  • docker-php-ext-install is meant for core modules with source bundled
  • gnupg extension requires the gpgme library

also killed some snakes while here:

  • runtime stage doesn't need vpx/webp/xpm dev packages

runtime libraries remain correctly installed:

docker build -t php5.6 -f Dockerfile.php5.6 .
docker run --rm -t php5.6 ldd '/usr/local/lib/php/extensions/no-debug-non-zts-20131226/*.so' | grep 'not found'
docker build -t php7.0 -f Dockerfile.php7.0 .
docker run --rm -t php7.0 ldd '/usr/local/lib/php/extensions/no-debug-non-zts-20151012/*.so' | grep 'not found'
docker build -t php7.1 -f Dockerfile.php7.1 .
docker run --rm -t php7.1 ldd '/usr/local/lib/php/extensions/no-debug-non-zts-20160303/*.so' | grep 'not found'
docker build -t php7.2 -f Dockerfile.php7.2 .
docker run --rm -t php7.1 ldd '/usr/local/lib/php/extensions/no-debug-non-zts-zts-20170718/' | grep 'not found'

@jcshort
jcshort requested a review from dbrian August 8, 2018 19:12

@dbrian dbrian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@jcshort
jcshort merged commit 0ea8887 into master Aug 8, 2018
@jcshort
jcshort deleted the stretch branch August 8, 2018 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants