Skip to content

Fixes #320, --path relative & absolute values handled - #328

Closed
erwanlr wants to merge 0 commit into
wp-cli:masterfrom
erwanlr:master
Closed

erwanlr wants to merge 0 commit into
wp-cli:masterfrom
erwanlr:master

Conversation

@erwanlr

@erwanlr erwanlr commented Feb 26, 2013

Copy link
Copy Markdown
Contributor

No description provided.

@scribu

scribu commented Feb 26, 2013

Copy link
Copy Markdown
Member

How about this:

We keep #327 focused on making wp core download --path work.

You rewrite your branch and focus on fixing set_wp_root().

@erwanlr

erwanlr commented Feb 26, 2013

Copy link
Copy Markdown
Contributor Author

Just one thing about your commit : you must create the ABSPATH is it does not exist ;)

Comment thread .gitignore Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a global .gitignore file instead.

@scribu

scribu commented Feb 26, 2013

Copy link
Copy Markdown
Member

Just one thing about your commit : you must create the ABSPATH is it does not exist ;)

Done: fe7683f

@erwanlr erwanlr closed this Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants