Repository navigation
Fix path handling in core download - #327
Merged
Merged
Conversation
Contributor
|
It fails because of this : if ( false === strpos( $command, '--path' ) ) {
$command .= \WP_CLI\Utils\assoc_args_to_str( array(
'path' => $this->install_dir
) );
}e.g : when the command has a pipe like |
Member
Author
|
Hm... guess I'll have to make the injection procedure smarter. Thanks for investigating. |
This makes it clearer that running arbitrary commands is not supported.
scribu
pushed a commit
that referenced
this pull request
Feb 27, 2013
Fix path handling in `core download`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#320 exposed a bug in
core download, as well as a weakness in the way the functional tests are run.