Skip to content

Fix path handling in core download - #327

Merged
scribu merged 6 commits into
masterfrom
fix-core-download
Feb 27, 2013
Merged

scribu merged 6 commits into
masterfrom
fix-core-download

Conversation

@scribu

@scribu scribu commented Feb 26, 2013

Copy link
Copy Markdown
Member

#320 exposed a bug in core download, as well as a weakness in the way the functional tests are run.

@erwanlr

erwanlr commented Feb 27, 2013

Copy link
Copy Markdown
Contributor

It fails because of this :

        if ( false === strpos( $command, '--path' ) ) {
            $command .= \WP_CLI\Utils\assoc_args_to_str( array(
                'path' => $this->install_dir
            ) );
        }

e.g : when the command has a pipe like wp user list | wc -l, the --path is not at the right place : wp user list | wc -l --path='/tmp/wp-cli-test-512dd489ed31d3.92337052'

@scribu

scribu commented Feb 27, 2013

Copy link
Copy Markdown
Member Author

Hm... guess I'll have to make the injection procedure smarter. Thanks for investigating.

scribu pushed a commit that referenced this pull request Feb 27, 2013
Fix path handling in `core download`
@scribu
scribu merged commit 8900b0e into master Feb 27, 2013
@scribu
scribu deleted the fix-core-download branch February 27, 2013 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants