Force an integer for the return of Shell::columns(). In cases such as a ...#42
Merged
Conversation
… a cron job for which there's actually not a terminal, this call will return an empty string, which in turn causes $size in Bar::display() to be negative, which in turn causes a php warning because the second parameter to str_repeat() must be >= 0.
…as the second parameter sent to str_repeat(), which results in a php warning.
Contributor
|
So it would. Thanks for the fix! |
jlogsdon
added a commit
that referenced
this pull request
Jan 15, 2014
Force an integer for the return of Shell::columns(). In cases such as a ...
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...cron job for which there's actually not a terminal, this call will return an empty string, which in turn causes $size in Bar::display() to be negative, which in turn causes a php warning because the second parameter to str_repeat() must be >= 0.