Skip to content

changes var to let in variables - #246

Merged
ledsun merged 1 commit into
workshopper:es6from
lksei:variables_to_es6
Nov 16, 2018
Merged

changes var to let in variables#246
ledsun merged 1 commit into
workshopper:es6from
lksei:variables_to_es6

Conversation

@lksei

@lksei lksei commented Oct 21, 2018

Copy link
Copy Markdown

contribution to issue #229

@AnshulMalik

Copy link
Copy Markdown
Contributor

Okay, this one will be interesting, so since this is variables exercise itself.
Earlier we had just var, now we have let and const, we should update this exercise to educate how they work and how they are different.
We can have this change in this PR itself or another one as you like @a0viedo :)

@lksei
lksei changed the base branch from master to es6 October 21, 2018 06:47
@lksei

lksei commented Oct 21, 2018

Copy link
Copy Markdown
Author

Sounds well, we use this workshopper every meetup of nodeschool/spb community and can teach es6 tasks to our students
@AnshulMalik @a0viedo thanks for javascripting 👍

@AnshulMalik

Copy link
Copy Markdown
Contributor

Yeah, it's a nice place to learn. You can add those changes here or in another PR @alexey-pd

@lksei lksei mentioned this pull request Nov 1, 2018

@a0viedo a0viedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a0viedo

a0viedo commented Nov 15, 2018

Copy link
Copy Markdown
Member

if someone else would like to review the PR that would be amazing @workshopper/core

@ledsun
ledsun merged commit cb94fb4 into workshopper:es6 Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants