switched number-to-string to const - #230
Merged
AnshulMalik merged 1 commit intoOct 18, 2018
Merged
Conversation
Contributor
Contributor
|
@AnshulMalik @cbonaudo This merge needs to be reverted. They all should be |
Contributor
|
Ohh, nice catch :) |
AnshulMalik
added a commit
that referenced
this pull request
Oct 18, 2018
This reverts commit 65d5e7b.
AnshulMalik
added a commit
that referenced
this pull request
Oct 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the problem number-to-string (all languages) and the solution number-to-string, I replaced 'var' to 'const', since it does not need to be reassigned.