Skip to content

Replace var with const and let in accessing-array-values - #228

Merged
AnshulMalik merged 1 commit into
workshopper:es6from
AryanJ-NYC:es6
Oct 18, 2018
Merged

Replace var with const and let in accessing-array-values#228
AnshulMalik merged 1 commit into
workshopper:es6from
AryanJ-NYC:es6

Conversation

@AryanJ-NYC

Copy link
Copy Markdown
Contributor

Contributes to #212

@ledsun ledsun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Const is also supported in Node.js 5, so I think it looks nice.

@itzsaga
itzsaga self-requested a review October 17, 2018 14:44
@itzsaga

itzsaga commented Oct 17, 2018

Copy link
Copy Markdown
Member

This should be done across all the lessons and not just this one. Or else this will seem out of place when people run across it.

@AryanJ-NYC

Copy link
Copy Markdown
Contributor Author

Hey @itzsaga. I completely agree. Perhaps it'd be best to create an es6 branch on the repository as is being done over at workshopper/learnyounode#559? This way I can put in multiple units of time to getting this done rather than having it all done in bulk?

Thoughts?

@itzsaga

itzsaga commented Oct 17, 2018

Copy link
Copy Markdown
Member

Great idea @AryanJ-NYC.

@itzsaga

itzsaga commented Oct 18, 2018

Copy link
Copy Markdown
Member

Okay, @AryanJ-NYC I've created the new es6 branch and changed the target of this PR to that.

@itzsaga
itzsaga changed the base branch from master to es6 October 18, 2018 02:27
@AnshulMalik
AnshulMalik merged commit cf34563 into workshopper:es6 Oct 18, 2018
@AryanJ-NYC
AryanJ-NYC deleted the es6 branch October 18, 2018 14:18
@AryanJ-NYC
AryanJ-NYC restored the es6 branch October 18, 2018 14:18
@AryanJ-NYC
AryanJ-NYC deleted the es6 branch October 18, 2018 14:18
@AryanJ-NYC
AryanJ-NYC restored the es6 branch October 18, 2018 14:19
AnshulMalik added a commit that referenced this pull request Oct 18, 2018
AnshulMalik added a commit that referenced this pull request Oct 21, 2018
* Revert "Replace var with const and let in accessing-array-values (#228)"

This reverts commit cf34563.

* Revert "switched number-to-string to const (#230)"

This reverts commit 65d5e7b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants