Substituted var with let/const; new lesson scope-2 - #214
Conversation
Substituted the var keyword with const/let. Newcomers should learn the modern stuff right from the start. Adapted the description of the variable lesson (Enlish version only). Added new lesson scope-2 (English only). Adapted text of lesson scope (now sets the stage to the new lesson scope-2) (English only).
|
Hey @huberv This is great! |
|
Hi @AnshulMalik, that's definitely true, but from my point of view it doesn't make sense to split up the change from "var" to "const" or "let" into different pull requests => you'd have to accept all of them in order to get a consistent update. I know the changes are in lots of files, but each individual change is quite small... |
SomeoneWeird
left a comment
SomeoneWeird
left a comment
There was a problem hiding this comment.
I'm happy to merge this rather than splitting it into multiple PRs. If it was any other change I would recommend splitting it up, but this is easy to review and won't break anything.
|
Looks like it needs a rebase, then we are good to go. @huberv |
|
@AnshulMalik Thanks for the review! I fixed the typo you found and updated the pull request according to the procedure described here: https://help.github.com/articles/syncing-a-fork/ (I'm not in love with rebasing repos). |
|
Hi there, any news with regards to this PR? I think it would make a lot of sense to include these changes and start introducing more modern features. Anything I can do to help? |
|
@lupomontero well, currently there's a conflict on this PR. So resolving that would be a first step. |
|
@lupomontero @itzsaga I'd appreciate if my pull request would finally make it into the master. Because the pull request has been waiting for quite some time I suggest that somebody pulls from the master to my pull request, does a code review and then merges the pull request into the master. |
|
#265 is the same change as this PR. |
7 participants
Hi all,
I modernized the lessons somewhat:
I'd be glad if you would incorporate the changes in order to allow newbees to use a modern JavaScript style right from the start.
Unfortunately I'm not aware of how the process for triggering translations of the other currently supported languages is. Please advise on this topic.