Skip to content

Use get_ipython imported from IPython rather than global namespace#119

Merged
wolph merged 1 commit intowolph:developfrom
matthewwardrop:mw_fix_jupyter_width
May 30, 2017
Merged

Use get_ipython imported from IPython rather than global namespace#119
wolph merged 1 commit intowolph:developfrom
matthewwardrop:mw_fix_jupyter_width

Conversation

@matthewwardrop
Copy link
Copy Markdown
Contributor

@matthewwardrop matthewwardrop commented May 27, 2017

Upstream IPython discourages using get_ipython from global namespace, and it seems not to be present in newer notebook versions, leading to poor choice of terminal width.

@matthewwardrop matthewwardrop force-pushed the mw_fix_jupyter_width branch from 0ebe9fd to fac56a0 Compare May 27, 2017 00:25
@wolph wolph merged commit fac56a0 into wolph:develop May 30, 2017
wolph added a commit that referenced this pull request May 30, 2017
Fixed several bugs thanks to @matthewwardrop and refactored requirements

 - #119 Use get_ipython imported from IPython rather than global namespace
 - #118 Make printing a newline on finish optional
 - #117 Fix unwrapping stdout/stderr
 - Refactored `requirements.txt` files to use `setup.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants