Make printing a newline on finish optional#118
Merged
wolph merged 1 commit intowolph:developfrom May 30, 2017
Merged
Conversation
Owner
|
Useful fix, thanks :) Because of Python 2 it should be fetched from |
Contributor
Author
|
That's odd. It works here on my Python 2. Support for this syntax must have been added partway through the python 2.7 series. Will fix. |
Owner
|
That's odd indeed, I didn't know they backported support for keyword arguments after The fix looks great though, thanks for all the help :) |
Sometimes, like if the progressbar is used as part of logging, it is useful to be able to overwrite the progress bar simply using `\r`, which is made more difficult by this dangling newline. This PR makes that optional (the keyword argument name can be changed... chosen here to match the `print` function).
wolph
added a commit
that referenced
this pull request
May 30, 2017
Fixed several bugs thanks to @matthewwardrop and refactored requirements - #119 Use get_ipython imported from IPython rather than global namespace - #118 Make printing a newline on finish optional - #117 Fix unwrapping stdout/stderr - Refactored `requirements.txt` files to use `setup.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, like if the progressbar is used as part of logging, it is useful to be able to overwrite the progress bar simply using
\r, which is made more difficult by this dangling newline. This PR makes that optional (the keyword argument name can be changed... chosen here to match theprintfunction).