Skip to content

patch for #104#105

Merged
wolph merged 2 commits intowolph:developfrom
keriszafir:develop
Apr 4, 2017
Merged

patch for #104#105
wolph merged 2 commits intowolph:developfrom
keriszafir:develop

Conversation

@keriszafir
Copy link
Copy Markdown
Contributor

No description provided.

@wolph
Copy link
Copy Markdown
Owner

wolph commented Apr 4, 2017

I think it's a good fix but unfortunately I have no tests yet to verify this fixes anything :(

I'll keep trying to find a working test

@wolph wolph merged commit 433bec7 into wolph:develop Apr 4, 2017
wolph added a commit that referenced this pull request Apr 4, 2017
fixed unicode issues on python 3 (fixes #104, fixes #105, #fixes 106) v3.17.1
@wolph
Copy link
Copy Markdown
Owner

wolph commented Apr 5, 2017

Due to py.test using a different type of output wrapper (which is more tolerant) it seems this is not easily testable :(

The issue is fixed but I'm sad to say there aren't any automated tests to check for this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants