Skip to content

Fix name should be string error #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wikiped merged 1 commit into from
May 26, 2017
Merged

Fix name should be string error #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pptx/slide.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,11 @@ def name_to_attr(name, instance):
and then checks if the name is valid identifier
and it is available for given instance.
"""
new_name = name.title().replace(' ', '')
if new_name.isidentifier() and not hasattr(instance, new_name):
return new_name
from .compat import is_string
if is_string(name):
new_name = name.title().replace(' ', '')
if new_name.isidentifier() and not hasattr(instance, new_name):
return new_name

available_layouts = []
for layout_id in self._sldLayoutIdLst:
Expand All @@ -380,8 +382,8 @@ def name_to_attr(name, instance):
attr_name = name_to_attr(layout_name, self)
if attr_name:
setattr(self, attr_name, layout)
if not hasattr(self, 'available_layouts'):
setattr(self, 'available_layouts', available_layouts)
if available_layouts and not hasattr(self, 'available_layouts'):
setattr(self, 'available_layouts', available_layouts)


class SlideMaster(_BaseMaster):
Expand Down