Skip to content

Stubtest failed on Sat Mar 05 2022 #7441

Closed

Description

@github-actions

Activity

  1. AlexWaygood commented on Mar 5, 2022

    @AlexWaygood
    Member

    Many, many failures.

  2. hauntsaninja commented on Mar 5, 2022

    @hauntsaninja
    Collaborator

    I'm reverting checking positional-only differences on dunders in python/mypy#12293, as previously discussed in #7344 (comment)
    There are other failures, but these are the majority and the busy-work-est of them.

    This way we keep typeshed and stubtest master in a mostly reconcilable state and we can then ship improvements at our leisure.

  3. hauntsaninja commented on Mar 5, 2022

    @hauntsaninja
    Collaborator

    I misdiagnosed a little bit, looks like some of the positional-only differences was something stubtest always reported, but interacts a little unfortunately with python/mypy#12203.

    python/mypy#12294 changes things to ignore those as well.

    Once typeshed CI is green, we can look into potentially reverting python/mypy#12293 and python/mypy#12294. In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.

  4. AlexWaygood commented on Mar 5, 2022

    @AlexWaygood
    Member

    In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.

    I like this idea a lot :)

  5. hauntsaninja commented on Mar 7, 2022

    @hauntsaninja
    Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions