You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm reverting checking positional-only differences on dunders in python/mypy#12293, as previously discussed in #7344 (comment)
There are other failures, but these are the majority and the busy-work-est of them.
This way we keep typeshed and stubtest master in a mostly reconcilable state and we can then ship improvements at our leisure.
I misdiagnosed a little bit, looks like some of the positional-only differences was something stubtest always reported, but interacts a little unfortunately with python/mypy#12203.
Once typeshed CI is green, we can look into potentially reverting python/mypy#12293 and python/mypy#12294. In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.
Activity
AlexWaygood commentedon Mar 5, 2022
Many, many failures.
hauntsaninja commentedon Mar 5, 2022
I'm reverting checking positional-only differences on dunders in python/mypy#12293, as previously discussed in #7344 (comment)
There are other failures, but these are the majority and the busy-work-est of them.
This way we keep typeshed and stubtest master in a mostly reconcilable state and we can then ship improvements at our leisure.
Revert "stubtest pos-only differences in dunders (#12184)" (#12293)
hauntsaninja commentedon Mar 5, 2022
I misdiagnosed a little bit, looks like some of the positional-only differences was something stubtest always reported, but interacts a little unfortunately with python/mypy#12203.
python/mypy#12294 changes things to ignore those as well.
Once typeshed CI is green, we can look into potentially reverting python/mypy#12293 and python/mypy#12294. In particular, I think one way forward is to not check for positional-only differences in the case where stub inherits the relevant dunder.
AlexWaygood commentedon Mar 5, 2022
I like this idea a lot :)
hauntsaninja commentedon Mar 7, 2022
Green again! https://github.com/python/typeshed/actions/workflows/daily.yml