This repository was archived by the owner on Aug 7, 2024. It is now read-only.
Merged
Conversation
Contributor
Dakuan
commented
May 31, 2016
Dakuan
commented
- clear entry point for app
- export app object
- import app into a spec file
Contributor
Author
|
@jacobwalton @debugwand @icodejs Interested in your thoughts on this |
|
Yeah this is a bit clearer on how to expose the methods used within the app, for unit testing purposes! Admittedly, your first implantation tripped me up :) |
|
Big 👍 |
Contributor
Author
|
ok merged. FWIW, here is how I tested mine: https://github.com/Dakuan/fe-techtest/blob/master/spec/app-spec.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.