Repository navigation
Preserve allowed-value types in membership assertions - #372
Open
Gabrieljr42 wants to merge 2 commits into
Open
Gabrieljr42 wants to merge 2 commits into
Gabrieljr42 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269.
Psalm can now narrow
Assert::oneOf($value, ['red', 'blue'])to'red'|'blue'. The hook resolvesvalueandvaluesby parameter name, so reordered calls such asAssert::oneOf(values: $allowed, value: $candidate)narrow the candidate and return value correctly. The fixtures also cover array-valued candidates.This applies to
inArrayand the nullable and collection variants as well. Collection assertions retain keys, optional fields and permitted null entries, and remove non-iterable alternatives after a successful assertion. Membership narrowing is handled by the hook, avoiding Psalm's positional handling of the previous assertion annotations. Runtime membership checks are unchanged.Validation on PHP 8.4.22 with the locked tools:
Psalm was invoked directly with one worker on Windows because the Composer wrapper's
$(pwd)argument does not work in this shell.